Skip to content

Docs: improved seeEmailIsSent description #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2020

Conversation

ThomasLandauer
Copy link
Member

Added info about Console, see Codeception/Codeception#4698

Added info about Console, see Codeception/Codeception#4698
@TavoNiievez
Copy link
Member

Hey @ThomasLandauer , you're right 😃, currently the way emails are verified is through the Profiler, and that requires a web request. So that's right, currently Codeception can't detect emails sent via CLI... But it could :). I can think of several ways to implement this:

So this is another 'not yet implemented' issue, and i think it could be even better if an issue is opened requesting that feature. and instead of just saying "codeception can't do it", you could add a link to the issue in the description, so that people can see if someone has contributed that feature (and has been merged) or not.

@ThomasLandauer
Copy link
Member Author

Yeah, great! Judging from @DavertMik's answer (see above) I thought it's not possible in principle.

Would you create that issue? I can't say much - I would just copy your text from above... ;-)

@TavoNiievez
Copy link
Member

I personally would prefer to present the corresponding PR directly,
achieving this may involve editing various methods in the module, so i could try to implement it after the PRs i currently have open are merged or not (owners can ask me for changes there too).

@ThomasLandauer
Copy link
Member Author

Yeah, sure! I changed "Codeception cannot detect it." to "Codeception cannot detect it yet." - to give a hint that there's some progress underway.

So I'd say this docs PR here can be merged for now.

@Naktibalda Naktibalda changed the title Update Symfony.php Docs: improved seeEmailIsSent description Oct 31, 2020
@Naktibalda Naktibalda merged commit 132b64c into Codeception:master Oct 31, 2020
@ThomasLandauer ThomasLandauer deleted the patch-4 branch October 31, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants